Skip to content

updated examples for array/base/accessor-getter #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

updated examples for array/base/accessor-getter #6465

wants to merge 1 commit into from

Conversation

Rupa-Rd
Copy link
Contributor

@Rupa-Rd Rupa-Rd commented Mar 31, 2025

Resolves a part of #4833 .

Description

What is the purpose of this pull request?

This pull request:

  • It improves the examples for accessor-getter present in array/base/accessor-getter

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 31, 2025
stdlib-bot
stdlib-bot reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
array/base/accessor-getter $\color{green}199/199$
$\color{green}+100.00\%$ 		$\color{green}8/8$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}199/199$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Rupa-Rd Rupa-Rd mentioned this pull request Mar 31, 2025
Closed
7 tasks
@kgryte
Copy link
Member

kgryte commented Mar 31, 2025

@Rupa-Rd I think you misunderstand what is being asked in #4833, as none of the changes that you made in this PR are desired. The entire point of those examples is to demonstrate how the accessors work. As such, I am going to close this PR. Please feel free to open a different PR which updates the examples of another package having more appropriate examples.

@kgryte kgryte closed this Mar 31, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Improve doctests for complex number typed arrays in documentation examples
3 participants
@Rupa-Rd @stdlib-bot @kgryte